Rich-T-kid commented on code in PR #10958:
URL: https://github.com/apache/arrow-rs/pull/10958#discussion_r3926941157
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -2570,6 +2586,45 @@ where
}
}
+/// Returns `true` when the per-element checked conversion can be replaced by a
+/// plain widening conversion, that is when
Review Comment:
nit: this isnt 100% true right? it allows precision-losing integer-to-float
cases such as UInt64 -> Float32
I think we can say the operation is infallible or something of the sort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
