sdf-jkl commented on code in PR #10635:
URL: https://github.com/apache/arrow-rs/pull/10635#discussion_r3980950307
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -182,6 +182,9 @@ pub(crate) fn follow_shredded_path_element(
None => Ok(missing_path_step()),
}
}
+ VariantPathElement::ListElement => Err(ArrowError::NotYetImplemented(
Review Comment:
Sounds good. I suggested NYI because I wasn't sure whether we'd want to
support this later.
After checking, Spark's `variant_get` doesn't support `[*]` either.
`a.b[*]` selects all elements of the list, while `a.b` selects the whole
list itself as one value. Since `variant_get` only support singular paths, I
agree that `InvalidArgumentError` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
