unikdahal commented on code in PR #4747:
URL: https://github.com/apache/arrow-adbc/pull/4747#discussion_r4008893294
##########
java/driver/flight-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/FlightSqlConnection.java:
##########
@@ -208,11 +217,174 @@ public void setAutoCommit(boolean enableAutoCommit)
throws AdbcException {
}
}
+ @Override
+ public <T> T getOption(TypedKey<T> key) throws AdbcException {
+ final String k = key.getKey();
+
+ if (k.equals(FlightSqlConnectionProperties.SESSION_OPTIONS)) {
+ if (key.getType() != String.class) {
+ return AdbcConnection.super.getOption(key);
Review Comment:
`FlightSqlConnection` implements `AdbcConnection` directly, and this is
invoking the interface default method. Java requires the qualified
`AdbcConnection.super.getOption(...)` form here; plain `super.getOption(...)`
would look for a superclass implementation and won’t compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
