Copilot commented on code in PR #4781:
URL: https://github.com/apache/arrow-adbc/pull/4781#discussion_r4012500062
##########
c/meson.build:
##########
@@ -30,13 +30,22 @@ project(
],
)
+compiler_cc = meson.get_compiler('c')
add_project_arguments(
'-Wno-int-conversion',
'-Wno-unused-parameter',
language: 'c',
)
add_project_arguments('-Wno-unused-parameter', '-Wno-reorder', language: 'cpp')
+# On Windows the ADBC headers mark the public symbols as dllimport unless
+# ADBC_EXPORTING is defined; the libraries themselves must export them.
+if host_machine.system() == 'windows'
+ adbc_export_args = ['-DADBC_EXPORTING']
Review Comment:
This Windows-only export path is not exercised by the current CI:
`native-windows.yml` delegates C/C++ builds to `cpp_build.ps1`, which uses
CMake, while the Meson jobs run only on Unix. Since this PR specifically fixes
Windows Meson linking, please add a Windows/MSYS2 Meson configure/build/link
smoke test (ideally including the GLib consumer) so missing exports or system
libraries are caught automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
