zeroshade commented on code in PR #1311:
URL: https://github.com/apache/arrow-go/pull/1311#discussion_r4018770102
##########
arrow/compute/internal/kernels/filter_uint64_avx2_amd64.s:
##########
@@ -0,0 +1,79 @@
+//+build !noasm !appengine
Review Comment:
Non-blocking: the space in this legacy `+build` constraint means OR, so
`noasm`-only and `appengine`-only builds still include this assembly source.
`go list -tags noasm -f '{{.SFiles}}' ./arrow/compute/internal/kernels`
confirms it. The Go caller is excluded, so it remains unreachable. Please match
the uint32 sibling with `//go:build go1.18 && amd64 && !noasm && !appengine`
and preserve the constraint during regeneration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
