adamreeve commented on code in PR #51350:
URL: https://github.com/apache/arrow/pull/51350#discussion_r4022029104
##########
cpp/src/parquet/encryption/key_toolkit.h:
##########
@@ -77,7 +77,8 @@ class PARQUET_EXPORT KeyToolkit {
void RotateMasterKeys(const KmsConnectionConfig& kms_connection_config,
const std::string& parquet_file_path,
const std::shared_ptr<::arrow::fs::FileSystem>&
file_system,
- bool double_wrapping, double cache_lifetime_seconds);
+ bool double_wrapping, double cache_lifetime_seconds,
+ bool read_kms_url);
Review Comment:
It's expected that users should use the higher-level CryptoFactory instead
of this, but I've added this default value now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]