jaideeppyne opened a new pull request, #11104:
URL: https://github.com/apache/arrow-rs/pull/11104

   Fixes #11094.
   
   ## Summary
   
   - After unwrapping one dictionary/REE layer, `compare_op` now errors if the 
leftover type is still `Dictionary` or `RunEndEncoded`.
   - Add a regression: `eq` on `Dictionary<Int32, Dictionary<Int32, Utf8>>` 
returns `InvalidArgumentError` instead of panicking.
   
   ## Why
   
   `DataType::is_nested` is false for `Dictionary` and `RunEndEncoded`. Nested 
dictionaries therefore passed the existing nested/type-mismatch checks and fell 
into `downcast_primitive_array!`'s `unreachable!()` arm, taking down the caller 
thread. Other unsupported inputs already return `Err`.
   
   The check is on the leftover type after the one-level unwrap so primitive 
REE comparisons keep working.
   
   ## Validation
   
   - `cargo test -p arrow-ord --lib cmp::`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to