Jo2234 commented on PR #10361: URL: https://github.com/apache/arrow-rs/pull/10361#issuecomment-5695425301
I separated the shared leading-plus numeric-inference change into #11105. #10361 now leaves the schema-inference regexes unchanged and contains only the opt-in header-detection API and its tests. A conservative check within header detection retains numeric-looking first rows without changing the inferred schema. I merged current upstream into #10361 and resolved the test-location conflict while preserving the upstream Miri annotation. Both PRs now have no merge conflicts. The header branch passes 91 arrow-csv unit tests and 14 doctests; the numeric branch passes 86 and 13. Both pass the broader Arrow CSV-enabled tests (159 unit/integration tests and 11 doctests), Clippy with warnings denied, formatting, and diff checks on Rust 1.98.1. The numeric regression fails against the original regexes and passes with the fix. Header PR: https://github.com/apache/arrow-rs/pull/10361 Separate numeric PR: https://github.com/apache/arrow-rs/pull/11105 Hosted validation on #11105 has passed, and that PR is now ready for review. The earlier cancelled dev_pr run on #10361 was superseded by a successful run; no code-test failure was hidden by that cancellation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
