Adarsh-Me commented on PR #51315: URL: https://github.com/apache/arrow/pull/51315#issuecomment-5697630714
Ready for another look — pushed fixes for the 4 open review findings and rebased onto latest `main` (`b274238`). **Fixes** (commit `3f41597`): 1. **Probe gap**: CMake + Meson probes now compile `<format>` (`vformat_to`/`make_format_args`) and `std::chrono::locate_zone`, not just `__cpp_lib_chrono` (catches e.g. GCC 12, which advertises the macro but has no `<format>`). 2. **R startup**: `configure_tzdb()` checks `using_os_timezone_db` first and skips entirely — no more false "Timezones will not be available" when the tzdb package is missing on OS-db builds. 3. **Gandiva mix**: new `ARROW_HAVE_VENDORED_DATETIME` (CMake + Meson) records whether `datetime.cpp` is linked; `Initialize()` honors `timezone_db_path` for std+Gandiva builds (which still carry the vendored copy) and keeps rejecting it for pure-std builds. 4. **Subproject**: `config.cc` now includes `chrono_internal.h`, so `ARROW_DEFINE_OPTIONS=OFF` builds use the same backend predicate as the header (no more `using_os_timezone_db=false` on Windows-std); the `SetTimezoneConfig` skip follows it too. Also fixed the `cmake-format` lint failure on `CheckStdChrono.cmake` (try_compile layout). **Reds triage** on the previous head (`c1c045a`) — all CI-side except one to watch: - `Install/Download MinIO` failures: macOS 15-intel C++, ARM64 macOS 14 C++, MinGW MINGW64 + CLANG64 C++, macOS Python, Windows R release — MinIO infra, unrelated to this PR. - Windows 2022 MATLAB: failed at `Post Cache ccache` — infra flake. - Conda C++ AVX2: `Execute Docker Build` — looks infra-related; will confirm on the new head. - Windows 2022 AVX2 C++: failed at the `Test` step — please flag if still red on the new head and I'll dig into the log. - Lint `pre-commit`: only `cmake-format` on this PR's own file, fixed in this push. New CI is running on this head; will re-triage anything still red. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
