rok commented on code in PR #51216:
URL: https://github.com/apache/arrow/pull/51216#discussion_r4040061106
##########
cpp/src/arrow/util/chrono_internal.h:
##########
@@ -151,22 +127,172 @@ inline const time_zone* locate_zone(std::string_view
tz_name) {
inline const time_zone* current_zone() { return std::chrono::current_zone(); }
-// Formatting support - streams directly using C++20 std::vformat_to
-// Provides: direct streaming, stream state preservation, chaining, rich
format specifiers
+namespace detail {
+
+// Argument positions passed to std::vformat by to_stream below.
+enum class FormatArgument : char {
+ ZonedTime = '0',
+ TimeOfDay = '1',
+ TimeOfDayCount = '2',
+};
+
+template <typename CharT>
Review Comment:
Removed templating. Switched to char and moved this logic to
`kernels/temporal_internal.h`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
