rok commented on code in PR #51378:
URL: https://github.com/apache/arrow/pull/51378#discussion_r4045306232
##########
.github/workflows/matlab.yml:
##########
Review Comment:
See comment below.
```suggestion
- name: Restore ccache
uses:
apache/infrastructure-actions/stash/restore@ce952724eb5210790bd5d466d70d5d60ac3e6c21
```
##########
.github/workflows/matlab.yml:
##########
@@ -165,7 +165,7 @@ jobs:
with:
path: |
${{ steps.ccache-info.outputs.cache-dir }}
- key: matlab-ccache-windows-${{ hashFiles('cpp/**', 'matlab/**') }}
+ key: matlab-ccache-windows-${{ hashFiles('cpp/**', 'matlab/**',
'!matlab/build/**') }}
restore-keys: matlab-ccache-windows-
Review Comment:
ccache hashFiles seems to fails [because it can't resolve a symbolic link on
windows](https://github.com/apache/arrow/pull/51378#issuecomment-5721674308).
Given we switched away from hashFiles keys for [other caching
calls](https://github.com/search?q=repo%3Aapache%2Farrow+caching+to+apache%2Finfrastructure-actions%2Fstash&type=pullrequests)
I'd propose we take the same approach here if possible (copying from
[cpp_windows.yml](https://github.com/apache/arrow/blob/main/.github/workflows/cpp_windows.yml)).
It would likely also improve cache utilization. @pitrou ?
(I did not check if cache key is good enough)
Perhaps this is out of scope here and can be a separate PR, up to you
@raulcd.
```suggestion
key: matlab-ccache-windows
restore-keys: matlab-ccache-windows
- name: Build MATLAB Interface
```
##########
.github/workflows/matlab.yml:
##########
Review Comment:
```suggestion
- name: Save ccache
if: ${{ !cancelled() }}
continue-on-error: true
uses:
apache/infrastructure-actions/stash/save@ce952724eb5210790bd5d466d70d5d60ac3e6c21
with:
path: ${{ steps.ccache-info.outputs.cache-dir }}
key: matlab-ccache-windows
- name: Run MATLAB Tests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
