A-makarim commented on code in PR #51240: URL: https://github.com/apache/arrow/pull/51240#discussion_r4045645660
########## cpp/src/arrow/compute/kernels/copy_data_internal.h: ########## Review Comment: Yes, I checked the direct uses of the `uint8_t*` overload. They already pass an absolute bit offset, including the source `ArraySpan::offset` (for example, `CopyValues` in `scalar_if_else.cc` passes `array.offset + in_offset`). The affected callers use the `ArraySpan` overload and pass an offset relative to that span, so adding `in.offset` there matches the fixed-width specializations and fixes the sliced boolean case. The raw-pointer overload still needs to remain accessible for callers that already supply an absolute offset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
