Copilot commented on code in PR #51000:
URL: https://github.com/apache/arrow/pull/51000#discussion_r4047681074
##########
cpp/src/arrow/compute/kernels/scalar_validity.cc:
##########
@@ -101,6 +104,34 @@ static void SetNanBits(const ArraySpan& arr, uint8_t*
out_bitmap, int64_t out_of
}
}
+// Maps `is_null` over the dictionary values and then through the indices, so
that
+// both NaN and null dictionary entries are reported, whatever the index type.
+static Status SetNullBitsFromDictionary(KernelContext* ctx, const ArraySpan&
arr,
+ const NullOptions& options, uint8_t*
out_bitmap,
+ int64_t out_offset) {
+ if (arr.length == 0) {
+ return Status::OK();
+ }
+ const auto& dict_type = checked_cast<const DictionaryType&>(*arr.type);
+ ARROW_ASSIGN_OR_RAISE(Datum dict_is_null,
Review Comment:
`checked_cast` is defined in `arrow::internal`, but it's used here
unqualified; this won't compile unless it’s qualified or imported (there’s
another unqualified `checked_cast` later in `IsNullExec`, too).
This issue also appears on line 171 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
