ayush-bothra commented on issue #45723: URL: https://github.com/apache/arrow/issues/45723#issuecomment-5743883317
Hello @pitrou, I've been looking into `FixedSizeListBuilder`. The child appends currently go through `value_builder_`, which is stored as a `std::shared_ptr<ArrayBuilder>`. `ArrayBuilder` exposes the safe `AppendNull(s)` APIs, but doesn't currently have a polymorphic `UnsafeAppendNull(s)` interface. Some concrete builders do have their own unsafe null/append operations, but they aren't uniform across all `ArrayBuilder` subclasses. Would the intended approach be to add an `UnsafeAppendNull(s)` virtual interface to `ArrayBuilder`? However, since the other builder types have their own unsafe append implementations I assume this is not the requirement. Is there a narrower abstraction you had in mind for allowing nested builders such as `FixedSizeListBuilder` to propagate unsafe null appends without falling back to `AppendNulls()` and its `Status`/`Reserve()` handling? also is this the actual requirement, or is it something completely different from what I am suggesting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
