Tpt commented on code in PR #10894:
URL: https://github.com/apache/arrow-rs/pull/10894#discussion_r4073744251
##########
arrow-pyarrow/src/lib.rs:
##########
@@ -463,6 +494,59 @@ impl FromPyArrow for RecordBatch {
}
}
+impl FromPyArrowUnchecked for RecordBatch {
+ unsafe fn from_pyarrow_bound_unchecked(value: &Bound<PyAny>) ->
PyResult<Self> {
Review Comment:
nit: it's quite sad to duplicate all the logic. What about sharing it in a
utility function that would take a `array_data_from_py_arrow: impl
Fn(&Bound<PyAny>) -> PyResult<ArrayData>` argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
