Jefffrey commented on code in PR #11179:
URL: https://github.com/apache/arrow-rs/pull/11179#discussion_r4078389166
##########
arrow-cast/src/parse.rs:
##########
Review Comment:
could we update doc here with new format
##########
arrow-cast/src/parse.rs:
##########
@@ -135,6 +135,16 @@ impl TimestampParser {
let time = time(hour, minute, second, 0)?;
Some((time, 17))
}
+ // 09:26
+ m if m & 0b111111 == 0b011011
+ && self.test(13, b':')
+ && !self.test(16, b':')
+ && !self.test(16, b'.') =>
Review Comment:
similarly here, we're checking for trailing `:` and `.` but the arm above
doesnt check that either, presumably leaving it to later machinery to reject it
##########
arrow-cast/src/parse.rs:
##########
@@ -135,6 +135,16 @@ impl TimestampParser {
let time = time(hour, minute, second, 0)?;
Some((time, 17))
}
+ // 09:26
+ m if m & 0b111111 == 0b011011
Review Comment:
i notice arm above doesnt do `& 0b111111`; is this significant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
