pitrou commented on code in PR #51038: URL: https://github.com/apache/arrow/pull/51038#discussion_r4081087789
########## cpp/src/arrow/util/simdjson_internal.cc: ########## @@ -581,4 +581,18 @@ Status ValidateJsonDocument(simdjson::ondemand::parser& parser, return ConsumeJsonValue(value); } +/// Returns the number of leading whitespace characters when trailing is false, +/// or the number of trailing whitespace characters when trailing is true. +// XXX We could try to SIMD-accelerate this routine. Review Comment: > I removed that part because the helper is now also used by the parser, where it may examine more bytes than the original chunker-only use case. If that assumption is still valid, I can restore the comment. Well, can you investigate to find out whether it still applies? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
