alamb commented on code in PR #11203:
URL: https://github.com/apache/arrow-rs/pull/11203#discussion_r4098250273
##########
arrow/benches/filter_kernels.rs:
##########
@@ -225,21 +225,21 @@ fn add_benchmark(c: &mut Criterion) {
c.bench_function(
format!("filter context fsb with value length {value_length} (kept
1/2)").as_str(),
- |b| b.iter(|| bench_built_filter(&filter, &filter_array)),
Review Comment:
Oh, man -- that is subtle
It is super confusing that `bench_built_filter` takes parameters in a
different order (filter, data) than `bench_filter` (data, filter)
```rust
c.bench_function("filter context f32 low selectivity (kept 1/1024)", |b| {
b.iter(|| bench_built_filter(&sparse_filter, &data_array))
});
let data_array = create_primitive_array::<Decimal128Type>(size, 0.0);
c.bench_function("filter decimal128 (kept 1/2)", |b| {
b.iter(|| bench_filter(&data_array, &filter_array))
});
```
I'll make a follow on PR to make them consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
