zeroshade commented on PR #1321:
URL: https://github.com/apache/arrow-go/pull/1321#issuecomment-5836229482
CI ran (I approved the pending workflow runs) and `Lint` failed. It is a
one-line-times-two fix, and the construct it is objecting to came from my own
review suggestion, so apologies for the round trip.
pre-commit runs golangci-lint with autofix and then fails the job if any
file changed. The diff it reports contains exactly one file:
```diff
--- a/parquet/internal/encoding/delta_byte_array.go
+++ b/parquet/internal/encoding/delta_byte_array.go
@@ -258,7 +258,7 @@ func (d *DeltaByteArrayDecoder) Discard(n int) (int,
error) {
- suffix := d.DeltaLengthByteArrayDecoder.decodeOne()
+ suffix := d.decodeOne()
@@ -275,7 +275,7 @@ func (d *DeltaByteArrayDecoder) Discard(n int) (int,
error) {
- suffix := d.DeltaLengthByteArrayDecoder.decodeOne()
+ suffix := d.decodeOne()
```
Lines 261 and 278. The change is semantically identical:
`DeltaByteArrayDecoder` defines no `decodeOne` of its own, so the unqualified
call resolves to the embedded `*DeltaLengthByteArrayDecoder` method. You
spelled out the receiver to make the ownership explicit, which is exactly what
I asked for when I suggested moving the helper onto
`DeltaLengthByteArrayDecoder` — the linter just prefers the promoted form.
Everything else in the job passed, and golangci-lint itself reported `0
issues`.
One thing in that log to ignore: there are two `parquet/schema/node.go` diff
blocks that look like findings. They are not. They are a `WARN` reporting that
staticcheck **skipped** that file ("conflicting edits from staticcheck and
staticcheck"), and `node.go` is neither touched by this PR nor present in the
modified-files diff. Nothing for you to do there.
The other 17 jobs were still running when the fail-fast watch stopped, so
they are unverified rather than failing. Once you push, the workflows will land
in `action_required` again since this is a fork — ping me or any maintainer and
we will approve the rerun. The review approval stands; this is the only thing
between it and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
