DKER2 opened a new pull request, #11231: URL: https://github.com/apache/arrow-rs/pull/11231
# Which issue does this PR close? - Closes #11228. # Rationale for this change Quoted VariantPath fields can contain a literal closing bracket, but the parser currently terminates the bracket segment at the first unescaped `]`, even when it appears inside matching quotes. This rejects paths such as `["a]b"]` and can silently split some field names into multiple path elements. # What changes are included in this PR? - Track the active quote while parsing a bracket path element. - Treat an unescaped `]` as the closing delimiter only outside matching quotes. - Preserve the existing `\]` escape behavior. - Document the quote-aware behavior. - Add regression coverage for single and double quotes, subsequent path elements, escaped quotes, and the legacy escaped spelling. # Are these changes tested? Yes. The following checks pass: - `cargo test -p parquet-variant` - `cargo clippy -p parquet-variant --all-targets --all-features -- -D warnings` - `cargo +stable fmt --all -- --check` - `git diff --check` # Are there any user-facing changes? Yes. Quoted VariantPath fields may now contain an unescaped `]`. Existing paths using `\]` remain supported. There are no public API changes. # AI usage OpenAI Codex was used to inspect the existing parser, help implement the quote-state change, add regression tests, and run validation. I reviewed the resulting code and test behavior and can own and debug the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
