Jefffrey commented on code in PR #11242:
URL: https://github.com/apache/arrow-rs/pull/11242#discussion_r4123036845
##########
arrow-cast/src/cast/mod.rs:
##########
Review Comment:
maybe we can deprecate `single_bool_to_numeric` too; its only used in our
codebase by parquet-variant-compute, and in a followup PR we can probably just
vendor it there (not much to gain by having it here 🤔)
##########
arrow/benches/cast_kernels.rs:
##########
@@ -257,6 +258,34 @@ fn cast_array(array: &ArrayRef, to_type: DataType) {
hint::black_box(cast(hint::black_box(array),
hint::black_box(&to_type)).unwrap());
}
+fn boolean_numeric_casts(c: &mut Criterion) {
Review Comment:
putting this as a separate group does make me wonder about the structure of
this file as a whole; as in why only these specific benches are special enough
to be a separate group from the rest below
also i wonder if this behaviour is worth adding 6 new benches for (is it
common to cast bool <-> numeric?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
