alamb opened a new pull request, #11252: URL: https://github.com/apache/arrow-rs/pull/11252
# Which issue does this PR close? Follow-up to #10901. # Rationale for this change #10901 made `CachedArrayReader::cleanup_consumed_batches` incremental by tracking a `cleaned_up_to` watermark. The existing consumer tests only inspect the shared cache contents, which are identical under the old rescan-from-zero loop and the new incremental one, so nothing exercised the watermark itself. # What changes are included in this PR? Test-only changes to `cached_array_reader.rs`: - Assert `cleaned_up_to` after each `consume_batch` in `test_consumer_removes_batches` and `test_consumer_cleanup_after_skip`, alongside the existing `outer_position` assertions. - Add a repeated consume at the same batch id and check the watermark stays put and the current batch remains cached. Verified locally that the new assertions fail if the watermark is never advanced or is off by one. # Are these changes tested? Yes, they are tests. # Are there any user-facing changes? No. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
