raulcd commented on code in PR #51280:
URL: https://github.com/apache/arrow/pull/51280#discussion_r4120977005
##########
ci/scripts/cpp_test.sh:
##########
@@ -143,15 +143,26 @@ if [ "${ARROW_USE_MESON:-OFF}" = "OFF" ] && \
# Search vcpkg before <prefix>/lib/cmake.
CMAKE_PREFIX_PATH="${VCPKG_ROOT}/installed/${VCPKG_DEFAULT_TRIPLET};${CMAKE_PREFIX_PATH}"
fi
+ ARROW_EXAMPLE_S3="${ARROW_S3:-OFF}"
+ if [ "${ARROW_ENABLE_THREADING:-ON}" = "OFF" ]; then
+ ARROW_EXAMPLE_S3=OFF
+ fi
Review Comment:
is this for Emscripten? Do we enable S3 for it? I am wondering why the
`ARROW_ENABLE_THREADING` check on top of `ARROW_EXAMPLE_S3="${ARROW_S3:-OFF}"`
is necessary.
##########
cpp/examples/minimal_build/CMakeLists.txt:
##########
@@ -49,3 +49,14 @@ if(ARROW_LINK_SHARED)
else()
target_link_libraries(arrow-example PRIVATE Arrow::arrow_static)
endif()
+
+option(ARROW_EXAMPLE_S3 "Verify S3 and static linking" OFF)
Review Comment:
Would `ARROW_EXAMPLE_S3_STATIC_CHECK` or `ARROW_S3_STATIC_CHECK` be a better
name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
