HippoBaro opened a new pull request, #11269: URL: https://github.com/apache/arrow-rs/pull/11269
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> NA # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> The row-group byte-limit calculation already runs under a guard that ensures the buffered row count is nonzero. Using checked division for that first calculation repeats the guard, while a separate zero-average filter and fallback value make the remaining-budget calculation more complicated than necessary. Simplify the arithmetic while preserving the existing split and flush decisions. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - Calculate average row bytes directly under the existing nonzero buffered-row guard. - Divide the remaining byte budget by that average using `checked_div`. - Remove the separate zero-average filter and redundant fallback value. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> All tests passing. # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
