lidavidm commented on code in PR #4822:
URL: https://github.com/apache/arrow-adbc/pull/4822#discussion_r4129266313
##########
go/adbc/driver/flightsql/flightsql_adbc_test.go:
##########
@@ -340,60 +317,131 @@ func TestADBCFlightSQL(t *testing.T) {
suite.Run(t, &DomainSocketTests{db: db})
}
-func TestFlightSQLTracingProducesTraceFiles(t *testing.T) {
+func executeFlightSQLTraceQuery(t *testing.T, tracingOpts map[string]string) {
+ t.Helper()
+
// TODO: Reuse example.CreateDB() here after apache/arrow-go#916
isolates
// the shared in-memory SQLite database per call.
Review Comment:
Incidental, but it seems this is fixed; or do we have a different reason now
to use our own database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
