HippoBaro commented on code in PR #11266:
URL: https://github.com/apache/arrow-rs/pull/11266#discussion_r4129336793
##########
parquet/src/encodings/encoding/mod.rs:
##########
@@ -175,6 +176,52 @@ pub(crate) mod private {
}
}
+fn unsupported_column_encoding(encoding: Encoding, physical_type: Type) ->
ParquetError {
+ if encoding == Encoding::ALP {
Review Comment:
Ugh. Apologies for the ALP thing, ALP was merged recently, and this code
dates from before, and I may have used an agent to rebase since... :shame-nun:
I’ve removed that validation layer and added the missing type checks
directly to the encoding-selection matches. `BIT_PACKED` again reports:
`Encoding BIT_PACKED is not supported`, without suggesting that another
physical type would work. Dictionary encodings also retain: `Cannot initialize
this encoding through this function.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
