raulcd commented on code in PR #51610: URL: https://github.com/apache/arrow/pull/51610#discussion_r4131866776
########## dev/release/verify-release-candidate.bat: ########## @@ -84,8 +84,9 @@ set PATH=%INSTALL_DIR%\bin;%PATH% mkdir !ARROW_SOURCE!\cpp\build pushd !ARROW_SOURCE!\cpp\build -@rem This is the path for Visual Studio Community 2017 -call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 +@REM Setup MSVC environment. Find the Visual Studio Path first. +for /f "usebackq delims=" %%i in (`"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath`) do set "VS_INSTALL_PATH=%%i" +call "%VS_INSTALL_PATH%\VC\Auxiliary\Build\vcvarsall.bat" x64 || exit /B 1 Review Comment: The Visual Studio 17 2022 generator is hardcoded independently of this change. What is proposing would have already failed so I'd rather keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
