pitrou commented on code in PR #50629:
URL: https://github.com/apache/arrow/pull/50629#discussion_r4131546452
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -94,134 +89,196 @@ inline void CheckNumberDecoded(int64_t number_decoded,
int64_t expected) {
constexpr std::string_view kErrorRepDefLevelNotMatchesNumValues =
"Number of decoded rep / def levels do not match num_values in page
header";
-} // namespace
+/// Throws if the decoder could not provide as many levels as the page header
announces.
+inline void CheckLevelsDecoded(int64_t number_decoded, int64_t expected) {
Review Comment:
All the levels-related facilities (except the legacy `LevelDecoder`) can
perhaps go into the new `level_decoder_internal.h`? `column_reader.cc` is much
too large for comfortable reading and it would be a good thing to remove some
weight from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
