Rich-T-kid commented on code in PR #11271:
URL: https://github.com/apache/arrow-rs/pull/11271#discussion_r4136398899
##########
arrow-select/benches/filter_bits.rs:
##########
@@ -86,5 +111,44 @@ fn add_benchmark(c: &mut Criterion) {
}
}
-criterion_group!(benches, add_benchmark);
+/// `filter_bits` on masks too large for the branch predictor to learn: the
+/// cases above repeat one 1024-word mask, whose per-word branches a recent
+/// core learns, which makes random masks look faster than a real filter.
+/// Lazy strategies only, which compress word by word
+fn add_large_benchmark(c: &mut Criterion) {
+ const SIZE: usize = 1 << 22;
Review Comment:
sounds like a good idea to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
