Copilot commented on code in PR #51658:
URL: https://github.com/apache/arrow/pull/51658#discussion_r4144779261
##########
r/R/dataset-scan.R:
##########
@@ -220,17 +220,9 @@ tail_from_batches <- function(batches, n) {
#' the result; use `FALSE` to evaluate `FUN` on all batches before returning
#' the reader.
#' @param ... Additional arguments passed to `FUN`
-#' @param .data.frame Deprecated argument, ignored
#' @return An `arrow_dplyr_query`.
#' @export
-map_batches <- function(X, FUN, ..., .schema = NULL, .lazy = TRUE, .data.frame
= NULL) {
- if (!is.null(.data.frame)) {
- warning(
- "The .data.frame argument is deprecated. ",
- "Call collect() on the result to get a data.frame.",
- call. = FALSE
- )
- }
+map_batches <- function(X, FUN, ..., .schema = NULL, .lazy = TRUE) {
Review Comment:
This removes a public argument after a multi-release deprecation, but the
current `r/NEWS.md` development section has no release note for it (or for the
finalized `pull()` behavior). Please document these user-facing changes,
listing the argument removal under breaking changes so users can prepare before
upgrading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
