sdf-jkl commented on PR #10850: URL: https://github.com/apache/arrow-rs/pull/10850#issuecomment-5916547031
> were these meant to be closed too? > > * [Parsing Decimal With Negative Exponent And Zero Scale Can Overflow #5762](https://github.com/apache/arrow-rs/issues/5762) > > * [Parsing decimals truncates extra digits, but casting them rounds extra digits #9410](https://github.com/apache/arrow-rs/issues/9410) > > * [Parsing zero scale numbers truncates instead of rounding the number #9422](https://github.com/apache/arrow-rs/issues/9422) > > * [add rounding logic and scale zero fix in parse_decimal to match parse_string_to_decimal_native behavior #7355](https://github.com/apache/arrow-rs/issues/7355) > > * [Decimal enhancements in arrow-cast #5068](https://github.com/apache/arrow-rs/issues/5068) They seem to be addressed here and pinned with regression tests: - #5762 -- test here https://github.com/apache/arrow-rs/blob/main/arrow-cast/src/parse.rs#L2956 - #9410 -- test here https://github.com/apache/arrow-rs/blob/main/arrow-cast/src/parse.rs#L3090 - #9422 -- test here https://github.com/apache/arrow-rs/blob/main/arrow-cast/src/parse.rs#L3040 - #7355 -- test here https://github.com/apache/arrow-rs/blob/main/arrow-cast/src/parse.rs#L3093-L3094 - #5068 -- test here [Rounding, line 3074](https://github.com/apache/arrow-rs/blob/main/arrow-cast/src/parse.rs#L3074); [scientific notation, line 3275](https://github.com/apache/arrow-rs/blob/main/arrow-cast/src/parse.rs#L3275); [CSV, line 1605](https://github.com/apache/arrow-rs/blob/main/arrow-csv/src/reader/mod.rs#L1605); [JSON, line 1831](https://github.com/apache/arrow-rs/blob/main/arrow-json/src/reader/mod.rs#L1831) - #9170 also superseded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
