kou commented on code in PR #1314:
URL: https://github.com/apache/arrow-java/pull/1314#discussion_r4149410127
##########
ci/docker/vcpkg-jni.dockerfile:
##########
@@ -18,6 +18,10 @@
ARG base
FROM ${base}
+# Archery requires Python 3.11 or newer.
+ENV CPYTHON_VERSION=cp311
+ENV PATH=/opt/python/${CPYTHON_VERSION}-${CPYTHON_VERSION}/bin:${PATH}
+
Review Comment:
Sorry... I was wrong... This should be fixed in apache/arrow:
https://github.com/apache/arrow/pull/51666
##########
dataset/CMakeLists.txt:
##########
@@ -17,6 +17,9 @@
find_package(ArrowDataset REQUIRED)
find_package(ArrowSubstrait REQUIRED)
+if(ARROW_S3)
+ find_package(ArrowS3 QUIET)
+endif()
Review Comment:
Can we use `REQUIRED` if we check `ARROW_VERSION`?
```suggestion
if(ARROW_S3 AND ARROW_VERSION VERSION_GREATER_EQUAL 26.0.0)
find_package(ArrowS3 REQUIRED)
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
