lidavidm commented on code in PR #4845:
URL: https://github.com/apache/arrow-adbc/pull/4845#discussion_r4161731330
##########
c/driver/sqlite/sqlite.cc:
##########
@@ -702,11 +704,10 @@ class SqliteConnection : public
driver::Connection<SqliteConnection> {
result.emplace_back(code, "ADBC SQLite Driver");
break;
case ADBC_INFO_DRIVER_VERSION:
- // TODO(lidavidm): fill in driver version
- result.emplace_back(code, "(unknown)");
+ result.emplace_back(code, "v" SQLITE_VERSION_STRING);
break;
case ADBC_INFO_DRIVER_ARROW_VERSION:
- result.emplace_back(code, NANOARROW_VERSION);
Review Comment:
I think I'd have to relax the check in the validation suite (and @eitsupi
has pointed out before we don't really have any convention, which we should
ideally define)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
