Copilot commented on code in PR #4847: URL: https://github.com/apache/arrow-adbc/pull/4847#discussion_r4163436909
########## c/driver/postgresql/copy/writer.h: ########## @@ -33,6 +33,14 @@ #include "../postgres_util.h" #include "copy_common.h" +#if defined(__SIZEOF_INT128__) +__extension__ using UInt128 = unsigned __int128; +#else +#include <boost/int128.hpp> Review Comment: When `__SIZEOF_INT128__` is unavailable (notably with MSVC), Meson builds and CMake builds with `ADBC_WITH_VENDORED_NANOARROW=OFF` cannot find the vendored header unless Boost.Int128 is installed separately. The PostgreSQL driver and COPY-test targets include `c/`, not `c/vendor/`. Vendored nanoarrow adds `c/vendor/` transitively in CMake, masking the problem in that configuration. Include `vendor/boost/int128.hpp` through the existing `c/` include root so the fallback reliably uses the vendored copy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
