Jefffrey commented on code in PR #11251:
URL: https://github.com/apache/arrow-rs/pull/11251#discussion_r4166545708
##########
arrow/benches/cast_kernels.rs:
##########
@@ -257,7 +257,26 @@ fn cast_array(array: &ArrayRef, to_type: DataType) {
hint::black_box(cast(hint::black_box(array),
hint::black_box(&to_type)).unwrap());
}
+fn add_boolean_text_benchmarks(c: &mut Criterion) {
Review Comment:
should we try to stay consistent with the other benchmarks in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]