adriangb commented on code in PR #11330:
URL: https://github.com/apache/arrow-rs/pull/11330#discussion_r4171078696
##########
parquet/src/arrow/push_decoder/reader_builder/mod.rs:
##########
@@ -178,6 +180,10 @@ pub(crate) struct RowGroupReaderBuilder {
/// The underlying data store
buffers: PushBuffers,
+
+ /// What each decoding stage fetches. Kept here because the filter is
+ /// moved out of the builder while a row group is decoded.
+ stages: Arc<StageSchedule>,
Review Comment:
Also for #10555:
[`scan_plan()`](https://github.com/apache/arrow-rs/blob/ec3b0d2c50ee1d475fc773b1bdb71752854669cc/parquet/src/arrow/push_decoder/mod.rs#L627)
returns an owned iterator that holds on to the schedule. It can't just borrow
the decoder, because you need to keep calling `push_ranges` / `try_decode`
(`&mut self`) while you hold the plan. I'll make it a plain field here and add
the `Arc` in #10555.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
