DKER2 opened a new pull request, #11349:
URL: https://github.com/apache/arrow-rs/pull/11349

   ### Which issue does this PR fix?
   Closes #11339
   
   ### Rationale & Proposed Changes
   `WriterProperties` currently supports configuring data page size limits both 
globally and per-column via `set_data_page_size_limit` and 
`set_column_data_page_size_limit`. However, `set_data_page_row_count_limit` 
could only be configured globally.
   
   This PR adds per-column support for the data page row count limit:
   1. Adds `WriterPropertiesBuilder::set_column_data_page_row_count_limit(self, 
col: ColumnPath, value: usize) -> Self`.
   2. Adds `WriterProperties::column_data_page_row_count_limit(&self, col: 
&ColumnPath) -> usize`.
   3. Stores `data_page_row_count_limit` in `ResolvedColumnProperties` and uses 
it inside `ColumnWriterImpl::should_add_data_page()` and `base_batch_size`.
   4. Adds unit tests in `properties.rs` and `column/writer/mod.rs`.
   
   ### How Has This Been Tested?
   - Added unit tests:
     - `test_writer_properties_column_data_page_row_count_limit`
     - `test_writer_properties_panic_on_zero_column_data_page_row_count_limit`
     - `test_column_writer_column_data_page_row_count_limit`
   - Ran full test suite: `cargo test -p parquet` (All unit tests & doctests 
passed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to