rustyconover commented on PR #9445: URL: https://github.com/apache/arrow-rs/pull/9445#issuecomment-5981388909
Rebased onto current `main` and switched the field to `arrow_schema::Metadata` (from #10075), as discussed there. This removes the `CustomMetadata` alias, the custom `PartialEq`, and the empty/`None` special-casing (@alamb). `Metadata` guarantees empty is never allocated, `custom_metadata()` returns `&Metadata` so callers can share the `Arc` via `as_arc()`, and `with_custom_metadata` takes `impl Into<Metadata>`. `RecordBatch` grows by one pointer (40 → 48 bytes), clones share the map, and IPC encoding is now in sorted key order. I also added filter/take preservation tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
