Copilot commented on code in PR #4773:
URL: https://github.com/apache/arrow-adbc/pull/4773#discussion_r4181149614
##########
c/driver/sqlite/statement_reader.c:
##########
@@ -343,10 +343,41 @@ AdbcStatusCode InternalAdbcSqliteBinderBindNext(struct
AdbcSqliteBinder* binder,
binder->param_indices[i] =
sqlite3_bind_parameter_index(stmt, binder->schema.children[i]->name);
Review Comment:
Arrow schema fields may have a NULL name, and the binder does not reject
them. With bind-by-name enabled for `SELECT :a`, an unnamed field reaches this
fallback after the exact lookup returns 0. The new `strcmp` then dereferences
NULL and can crash the process. Reject unnamed fields before name resolution,
reset the cached-index sentinel on failure, and add a native regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
