Jefffrey commented on code in PR #11386:
URL: https://github.com/apache/arrow-rs/pull/11386#discussion_r4185065603
##########
.github/workflows/dev_pr.yml:
##########
@@ -18,7 +18,7 @@
name: dev_pr
concurrency:
- group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ group: ${{ github.repository }}-${{ github.event.pull_request.number }}-${{
github.workflow }}
Review Comment:
this was something identified by codex on the side; if PRs from different
forks have same name it can cause issues, so we rely on PR number to avoid
conflicts. this follows what we do in other workflows:
https://github.com/apache/arrow-rs/blob/103ebe7548db35c37e8ff35fcb02438bcd182fa7/.github/workflows/ci.yml#L27-L29
since this runs only on PRs, we dont need a fallback to `github.sha`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
