zeroshade commented on code in PR #1359:
URL: https://github.com/apache/arrow-go/pull/1359#discussion_r4197916799
##########
arrow/compute/internal/kernels/vector_selection.go:
##########
@@ -742,13 +734,13 @@ func newChunkedBinaryGetter[OffsetT int32 | int64](arr
*arrow.Chunked) *chunkedB
return getter
}
-func (c *chunkedBinaryGetter[OffsetT]) IsValid(i int64) bool {
+func isChunkedBinaryValueValid[OffsetT int32 | int64](c
*chunkedBinaryGetter[OffsetT], i int64) bool {
Review Comment:
Consider keeping `IsValid`/`GetValue` as methods. Once the parameter is the
concrete `*chunkedBinaryGetter[OffsetT]`, calling them as methods is just as
direct: I benchmarked that variant and it performed the same as the free
functions. `NullCount`/`Len`/`DataLen` are still methods too, so the type would
be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
