alamb commented on code in PR #11393:
URL: https://github.com/apache/arrow-rs/pull/11393#discussion_r4211218168
##########
parquet/src/arrow/push_decoder/reader_builder/mod.rs:
##########
@@ -761,28 +762,37 @@ impl RowGroupReaderBuilder {
/// final projection, excluding any nested columns.
fn compute_cache_projection(&self, row_group_idx: usize, filter:
&RowFilter) -> ProjectionMask {
let meta = self.metadata.row_group(row_group_idx);
- match self.compute_cache_projection_inner(filter) {
+ let cache_projection = Self::compute_cache_projection_inner(
+ filter,
+ &self.projection,
+ &self.metadata,
+ self.max_predicate_cache_size,
+ );
+ match cache_projection {
Some(projection) => projection,
None => ProjectionMask::none(meta.columns().len()),
}
}
- fn compute_cache_projection_inner(&self, filter: &RowFilter) ->
Option<ProjectionMask> {
+ /// An associated function, so that [`Self::new`] can call it before the
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
