osipovartem commented on code in PR #11411:
URL: https://github.com/apache/arrow-rs/pull/11411#discussion_r4211641700
##########
parquet-variant-compute/benches/variant_kernels.rs:
##########
@@ -530,6 +582,7 @@ criterion_group!(
shred_variant_partial_object_bench,
shred_variant_unmatched_object_bench,
variant_array_builder_build_bench,
+ benchmark_json_to_variant_inputs,
benchmark_batch_json_string_to_variant,
Review Comment:
Agreed. I removed the separate benchmark group and folded the incremental
JSON inputs into the existing `benchmark_batch_json_string_to_variant` function.
##########
parquet-variant-compute/benches/variant_kernels.rs:
##########
Review Comment:
I dropped the overlapping short-string and nested cases. The retained inputs
target Int32, fixed-point decimals, escaped strings, large arrays/strings, and
duplicate keys, which are not directly covered by the existing cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
