jhorstmann commented on code in PR #11408:
URL: https://github.com/apache/arrow-rs/pull/11408#discussion_r4222208527


##########
parquet/src/column/reader/decoder.rs:
##########
@@ -393,12 +409,28 @@ impl RepetitionLevelDecoderImpl {
     ///
     /// A "complete" record is one where the buffer contains a subsequent 
repetition level of 0
     fn count_records(&self, records_to_read: usize, num_levels: usize) -> 
(bool, usize, usize) {

Review Comment:
   The documentation for this method might need an update, I had to lookup that 
the bool meant partial records. And is it still "complete" records that we 
count if the partial flag is true?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to