thisisnic commented on code in PR #51662:
URL: https://github.com/apache/arrow/pull/51662#discussion_r4242406963


##########
r/NEWS.md:
##########
@@ -19,50 +19,16 @@
 
 # arrow 25.0.1.9000
 
-## Breaking changes
-
-- The `.data.frame` argument to `map_batches()`, deprecated since 9.0.0, has
-  been removed. Call `collect()` on the result to get a data frame (#51655).
-- `read_feather()` and `write_feather()` now warn that they are deprecated. Use
-  `read_ipc_file()` and `write_ipc_file()` instead. Similarly,
-  `format = "feather"` in `open_dataset()` and `write_dataset()` is deprecated
-  in favour of `format = "ipc"`, and extra arguments passed via `...` to
-  `read_ipc_stream()` and `write_ipc_stream()` are deprecated and ignored
-  (#49237).
-- `register_scalar_function()` now errors if the names in `in_type` do not
-  match the argument names of `fun`, instead of silently ignoring them
-  (#37761).
-
-## New features
-
-- New `AzureFileSystem` class and `az_container()` helper for working with
-  Azure Blob Storage, analogous to `S3FileSystem` and `s3_bucket()`. See
-  `vignette("install", package = "arrow")` for how to enable Azure support
-  when building from source (@marberts, #32123).
-
 ## Minor improvements and fixes
 
-- Variables with the same name as a function, such as `date`, can now be used
-  in dplyr verbs (#39688).
-- Reading Parquet files with `float16` columns now returns the correct values
-  (#50378).
-- `if_else()` now works when one branch is a bare `NA` and the other is a date
-  or timestamp (#38358).
-- `mutate()` with `if_any()` or `if_all()` now gives the new column the correct
-  name (#34860).
 - Factor levels inside list columns are now unified across the whole column
   when converting to R, so data read in multiple batches (e.g. via
   `read_ipc_stream()` or `open_dataset()`) produces valid factors that can be
   unnested. Similarly, `int64` and `uint32` values inside list columns are
   converted to a single R type across the column (#50514).
-- `pull()` on Arrow data no longer warns about a future change of default.
-  The planned switch to returning a `ChunkedArray` has been dropped, so
-  `pull()` will keep returning an R vector by default; use
-  `as_vector = FALSE` or `options(arrow.pull_as_vector = FALSE)` to get a
-  `ChunkedArray` (#51655).
-- `str_replace()` with an `NA` replacement now returns `NA` for matched
-  elements, matching stringr (@Gosling-dude, #33432).
-- `summarise()` after `arrange()` now works (#45373).
+
+- `csv_parse_options()` and `CsvParseOptions$create()` gain `pad_short_rows` 
and
+  `ignore_extra_columns`, exposing the new C++ parse options (#51659).

Review Comment:
   As you're not currently a named package author you should put your username 
next to the PR number in the news entry so we an acknowledge your contribution 
there :)



##########
r/NEWS.md:
##########
@@ -19,50 +19,16 @@
 
 # arrow 25.0.1.9000
 
-## Breaking changes
-
-- The `.data.frame` argument to `map_batches()`, deprecated since 9.0.0, has
-  been removed. Call `collect()` on the result to get a data frame (#51655).
-- `read_feather()` and `write_feather()` now warn that they are deprecated. Use
-  `read_ipc_file()` and `write_ipc_file()` instead. Similarly,
-  `format = "feather"` in `open_dataset()` and `write_dataset()` is deprecated
-  in favour of `format = "ipc"`, and extra arguments passed via `...` to
-  `read_ipc_stream()` and `write_ipc_stream()` are deprecated and ignored
-  (#49237).
-- `register_scalar_function()` now errors if the names in `in_type` do not
-  match the argument names of `fun`, instead of silently ignoring them
-  (#37761).
-
-## New features
-
-- New `AzureFileSystem` class and `az_container()` helper for working with
-  Azure Blob Storage, analogous to `S3FileSystem` and `s3_bucket()`. See
-  `vignette("install", package = "arrow")` for how to enable Azure support
-  when building from source (@marberts, #32123).
-
 ## Minor improvements and fixes
 
-- Variables with the same name as a function, such as `date`, can now be used
-  in dplyr verbs (#39688).
-- Reading Parquet files with `float16` columns now returns the correct values
-  (#50378).
-- `if_else()` now works when one branch is a bare `NA` and the other is a date
-  or timestamp (#38358).
-- `mutate()` with `if_any()` or `if_all()` now gives the new column the correct
-  name (#34860).
 - Factor levels inside list columns are now unified across the whole column
   when converting to R, so data read in multiple batches (e.g. via
   `read_ipc_stream()` or `open_dataset()`) produces valid factors that can be
   unnested. Similarly, `int64` and `uint32` values inside list columns are
   converted to a single R type across the column (#50514).
-- `pull()` on Arrow data no longer warns about a future change of default.
-  The planned switch to returning a `ChunkedArray` has been dropped, so
-  `pull()` will keep returning an R vector by default; use
-  `as_vector = FALSE` or `options(arrow.pull_as_vector = FALSE)` to get a
-  `ChunkedArray` (#51655).
-- `str_replace()` with an `NA` replacement now returns `NA` for matched
-  elements, matching stringr (@Gosling-dude, #33432).
-- `summarise()` after `arrange()` now works (#45373).
+
+- `csv_parse_options()` and `CsvParseOptions$create()` gain `pad_short_rows` 
and
+  `ignore_extra_columns`, exposing the new C++ parse options (#51659).

Review Comment:
   As you're not currently a named package author/contributor you should put 
your username next to the PR number in the news entry so we an acknowledge your 
contribution there :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to