andygrove commented on PR #11482: URL: https://github.com/apache/arrow-rs/pull/11482#issuecomment-6126053740
Thanks for the careful review, @viirya. Replies are inline. On the points in your summary: - dafbd244c adds `timezone::tzdb_version()`, which returns `jiff_tzdb::VERSION` with `jiff`, `chrono_tz::IANA_TZDB_VERSION` with `chrono-tz`, and `None` with neither. jiff doesn't expose the release it bundles, so arrow-array now depends on `jiff-tzdb` directly. It's the same copy jiff resolves to, so Cargo.lock gains no package. - The `timezone` module docs now describe both features. They say that enabling `jiff` anywhere in a build changes how every crate in it resolves named timezones, and that the bundled releases differ (2025b and 2026c today), so results can differ before 2100 too. The build-wide note is also in the arrow README and on `DataType::Timestamp`. While writing those docs I found a mistake in my description. After 2099, chrono-tz doesn't fall back to standard time; it keeps the offset of its last transition. Southern-hemisphere zones therefore stay on daylight time all year: `Australia/Sydney` is +11:00 in July 2150. I've corrected the description, and `test_dst_applies_after_2099` now checks Sydney as well as LA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
