amoeba commented on code in PR #4879:
URL: https://github.com/apache/arrow-adbc/pull/4879#discussion_r4263629042
##########
.github/workflows/packaging.yml:
##########
@@ -1159,6 +1198,20 @@ jobs:
Write-Host "::endgroup::"
}
+ - name: Test wheel 3.15
+ shell: pwsh
+ run: |
+ if (-not (Test-Path -Path
"adbc/python/adbc_driver_manager/repaired_wheels/*-cp315-cp315-win_*.whl"
-PathType Leaf)) {
+ throw "Python 3.15 driver manager wheel is missing"
+ }
+
+ - name: Test wheel 3.15t
+ shell: pwsh
+ run: |
+ if (-not (Test-Path -Path
"adbc/python/adbc_driver_manager/repaired_wheels/*-cp315-cp315t-win_*.whl"
-PathType Leaf)) {
+ throw "Python 3.15t driver manager wheel is missing"
+ }
+
Review Comment:
same
##########
.github/workflows/packaging.yml:
##########
@@ -914,6 +922,14 @@ jobs:
./ci/scripts/python_wheel_unix_test.sh $(pwd)
deactivate
+ - name: Test wheel 3.15
+ run: |
+ test -f
adbc/python/adbc_driver_manager/repaired_wheels/*-cp315-cp315-macosx*.whl
+
+ - name: Test wheel 3.15t
+ run: |
+ test -f
adbc/python/adbc_driver_manager/repaired_wheels/*-cp315-cp315t-macosx*.whl
+
Review Comment:
Same as above
##########
.github/workflows/packaging.yml:
##########
@@ -770,6 +770,14 @@ jobs:
pushd adbc
env PYTHON=3.14t docker compose run
python-wheel-manylinux-freethreaded-test
+ - name: Test wheel 3.15
+ run: |
+ test -f
adbc/python/adbc_driver_manager/repaired_wheels/*-cp315-cp315-manylinux*.whl
+
+ - name: Test wheel 3.15t
+ run: |
+ test -f
adbc/python/adbc_driver_manager/repaired_wheels/*-cp315-cp315t-manylinux*.whl
+
Review Comment:
Track actually testing these wheels as a TODO code comment?
##########
c/CMakeLists.txt:
##########
@@ -94,7 +94,7 @@ if(ADBC_INTEGRATION_DUCKDB)
endif()
if(ADBC_BUILD_PYTHON)
- find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
+ find_package(Python3 REQUIRED COMPONENTS Interpreter)
Review Comment:
Is this just cleanup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
