Jefffrey opened a new issue, #11548:
URL: https://github.com/apache/arrow-rs/issues/11548

   ### Is your feature request related to a problem or challenge?
   
   We enabled running Miri for all of our crates:
   
   - https://github.com/apache/arrow-rs/issues/10471
   - https://github.com/apache/arrow-rs/issues/614
   
   However this is extremely slow, as a result we needed to move it to run only 
in merge queue, otherwise running it also on main + PRs would burn lots of 
compute:
   
   - https://github.com/apache/arrow-rs/issues/11045
   
   But we can probably do better
   
   ### Describe the solution you'd like
   
   Instead of running it on each merge, perhaps run Miri only on a scheduled 
basis, e.g. weekly. I don't think Miri tests fail too often, and lots of 
changes we make are not going to impact them. To avoid burning compute, as well 
as make our merge queue faster, it might be better to schedule it.
   
   Some things to keep in mind:
   
   - How to ensure we know when Miri tests are failing? Need a way to notify us
   - Maybe need a way to manually invoke a Miri run on request for PRs
   - Consider for release prep, we should probably ensure for the release 
branch we have a clean Miri run
   
   ### Describe alternatives you've considered
   
   Keep Miri as is, running in merge queue only. Or perhaps run only on main 
and not in merge queue; difference is that merge queue can spuriously fail 
(e.g. due to archery) so we sometimes run Miri multiple times for same PR 
merge, whilst on main at least we're guaranteed one Miri run per commit
   
   ### Additional context
   
   Related
   
   - https://github.com/apache/arrow-rs/issues/11331
   - https://github.com/apache/arrow-rs/issues/11456
   - https://github.com/apache/arrow-rs/issues/11469
   - https://github.com/apache/arrow-rs/issues/10948


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to