sdf-jkl opened a new pull request, #11556:
URL: https://github.com/apache/arrow-rs/pull/11556
# Which issue does this PR close?
Follow-up to #11416.
# Rationale for this change
The existing `variant_get` decimal benchmarks cover integer and
floating-point
inputs, but not strings. These cases provide a baseline for measuring changes
to string parsing and decimal conversion.
# What changes are included in this PR?
Add six benchmarks covering four conversion paths:
- Short strings to Decimal32 in safe and strict modes.
- Strings longer than Variant's 63-byte short-string limit to Decimal128 in
safe and strict modes.
- Wide values to Decimal256, exercising accumulation beyond the Decimal128
range.
- Strings to Decimal256 with a negative scale, exercising the additional
integer-digit scan and scale-down path.
Fixtures contain 8,192 unshredded Variant rows with approximately 10% nulls
and
a fixed RNG seed. They reuse the existing `bench_variant_get_decimal` helper,
with fixture construction outside timing.
# Are these changes tested?
This PR adds benchmarks only. All six cases were smoke-tested on upstream
main
(`4dc6bc25f3`). Formatting and whitespace checks pass. No library behavior
changes or additional unit tests are included.
# Are there any significant user-facing changes?
No.
# AI usage
Developed with assistance from OpenAI Codex for implementation, validation,
and this description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
