CTTY commented on code in PR #11544:
URL: https://github.com/apache/arrow-rs/pull/11544#discussion_r4274683185
##########
parquet/src/arrow/schema/mod.rs:
##########
@@ -977,6 +977,49 @@ mod tests {
assert_eq!(&arrow_fields, converted_arrow_schema.fields());
}
+ #[test]
+ fn test_decimal_precision_physical_types() {
+ let cases = [
+ (1, PhysicalType::INT32, None),
+ (9, PhysicalType::INT32, None),
+ (10, PhysicalType::INT64, None),
+ (18, PhysicalType::INT64, None),
+ (
+ 19,
+ PhysicalType::FIXED_LEN_BYTE_ARRAY,
+ Some(decimal_length_from_precision(19) as i32),
Review Comment:
Updated in 1c8adc92bc3f93f2fb63659af194814b74456764. The fixed-length
byte-array expectations now assert independent literal lengths: 9 bytes for
precision 19 and 16 bytes for precision 38, rather than calling
decimal_length_from_precision. The table continues to cover the INT32, INT64,
and FIXED_LEN_BYTE_ARRAY boundaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
